refactor: move optional arguments of misc functions behind the ellipsis - #2778
Merged
Conversation
krlmlr
force-pushed
the
claude/ellipsis-misc
branch
2 times, most recently
from
July 26, 2026 11:09
7a65dfc to
ff7ed7c
Compare
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ff7ed7c is merged into main:
|
krlmlr
marked this pull request as ready for review
July 26, 2026 15:04
krlmlr
force-pushed
the
claude/ellipsis-misc
branch
from
July 26, 2026 16:24
ff7ed7c to
0f7d122
Compare
Insert `...` between the defining arguments and the optional modifiers of 5 functions, following the zoning rules in CONTRIBUTING.md. Legacy positional and abbreviated calls are recovered by the generated ARG_HANDLE blocks (registry: tools/migrations/misc.R) and emit a single soft deprecation for igraph 3.0.0. No defaults change and no arguments are renamed. Functions: graph_from_graphdb, greedy_vertex_coloring, sir, stochastic_matrix, time_bins Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
Add argument-coverage tests for the ellipsis-migrated misc functions: greedy_vertex_coloring(), stochastic_matrix(), sir(), time_bins() and graph_from_graphdb(). Each keyword-only tail argument is exercised by name with a real assertion, and the legacy positional recovery path is covered with its deprecation warning. graph_from_graphdb() needs the network, so its named-tail test skips when the database is unreachable and its recovery is proven offline via an invalid-prefix validation error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if bf4c095 is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide ellipsis migration coordinated in #2757 —
see that PR for the full rationale (CONTRIBUTING.md, Argument Order and the Ellipsis).
Based directly on
main(the registry split landed via #2779); a single topic commit.What this does
Inserts
...between the defining arguments (head) and the optionalmodifiers (tail) of 5 exported misc functions.
Arguments after
...become keyword-only.ARG_HANDLE block and emit a single
lifecycle::deprecate_soft("3.0.0", …)—behavior is unchanged.
tools/migrations/misc.R; blocks regenerated viaRscript tools/generate-migrations.R(idempotent, CI-checked).New signatures
greedy_vertex_coloring()graphheuristictime_bins()xmiddlegraph_from_graphdb()urlprefix, type, nodes, pair, which, base, compressed, directedsir()graph, beta, gammano.simstochastic_matrix()graphcolumn.wise, sparseNotes for review
igraph.r2cdocs(GitHub API unreachable), so
man/*.Rdfiles were updated mechanically(usage +
...argument item) instead of viadevtools::document().R CMD check's usage↔formals validation passes; a follow-up
devtools::document()run may reflow whitespace but should produce nosemantic diff.
named arguments (they are the same soft-deprecation user code will see).